smr15.js ➔ createRaceRadarChart - Code Metrics - Inspection of "Added Plot.ly graphs for Racial Strengths" - smrealms/smr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#947)

unknown

created 2020-12-12 21:43 UTC

smr15.js ➔ createRaceRadarChart B

↳ Parent: htdocs/js/smr15.js

Complexity

Conditions

Size

Total Lines	68
Code Lines	51

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	51
dl	0
loc	68
rs	8.6036
c	0
b	0
f	0

How to fix Long Method

(function() {
"use strict";

	window.voteSite = function(snUrl) {
		// Must not redirect the current page until after the external vote
		// site URL has been opened in a new tab. Use setTimeout to do this.
		setTimeout(function() {
			window.location = snUrl;
		}, 0);
	};

	function doCalc(type, number, totalDest) {
		var i = 1, total = 0, df=document.FORM;
		for(; i<=number; i++) {
			total += df[type+i].value * 1;
		}
		df[totalDest].value = total;
	};

	// Recalculate total number of ports, summing over level
	window.levelCalc = function(maxPortLevel) {
		doCalc('port', maxPortLevel, 'total');
	};

	// Recalculate sum of port race percentages
	window.raceCalc = function() {
		doCalc('race', 9, 'racedist');
	};

	// Set the total number of ports to zero
	window.setZero = function(maxPortLevel) {
		var df = document.FORM;
		for (var i=1; i<=maxPortLevel; i++) {
			df['port'+i].value = 0;
		}
		df.total.value = 0;
	};

	// Set the port race distribution to be equal
	window.setEven = function() {
		var i = 2, df=document.FORM;
		df.race1.value = 12;
		for(; i<=9; i++) {
			df['race'+i].value = 11;
		}
		df.racedist.value = 100;
	};

	var body, currentlyFlashing=false, flashColour, origColour, intervalFlash, timeoutStopFlash;

	function stopFlash() {
		clearInterval(intervalFlash);
		body.style.backgroundColor = origColour;

		currentlyFlashing = false;
	};

	function bgFlash() {
		var body = document.getElementsByTagName('body')[0];
		if(body.style.backgroundColor === origColour) {
			body.style.backgroundColor = flashColour;
		}
		else {
			body.style.backgroundColor = origColour;
		}
	};

	window.triggerAttackBlink = function(colour) {
		if(origColour == null) {

			origColour = document.getElementsByTagName('body')[0].style.backgroundColor;
		}
		flashColour = '#'+colour;
		clearTimeout(timeoutStopFlash);
		if (currentlyFlashing === false) {
			currentlyFlashing = true;
			//flash 3 times
			bgFlash();
			intervalFlash = setInterval(bgFlash,500);
		}
		timeoutStopFlash = setTimeout(stopFlash,3500);
	};
})();

// Used by shop_hardware.php
function recalcOnKeyUp(transaction, hardwareTypeID, cost) {
	var form = document.getElementById(transaction + hardwareTypeID);
	form.total.value = form.amount.value * cost;
}

// Used by planet_defense.php
function showWeaponInfo(select) {
	var target = $(select).data('target');
	var show = $("option:selected", select).data('show');
	$(target).children().addClass('hide');
	$(show).removeClass('hide');
}

// Used by game_join.php
function showRaceInfo(select) {
	var race_id = $("option:selected", select).val();
	document.getElementById('race_image').src = "images/race/race" + race_id + ".jpg";
	document.getElementById('graphframe').src = "images/race/graph/graph" + race_id + ".gif";
	var desc = document.getElementById('race_descr');
	$(desc).children().addClass('hide');
	$(".race_descr" + race_id, desc).removeClass('hide');
	createRaceRadarChart(race_id);
}

// Used by game_join.php 
function createRaceRadarChart(race_id) {

	var races = {
		1: [[1.0,  1.0,  1.0,  1.0,  1.0],  'Neutral',    '#FFD800'],
		2: [[5.2,  10.0, 5.8,  8.1,  5.2],  'Alskant',    '#FF00FF'],
		3: [[8.3,  5.0,  10.0, 3.3,  8.3],  'Creonti',    '#FF8000'],
		4: [[9.5,  4.9,  9.5,  7.7,  9.5],  'Human',      '#0000FF'],
		5: [[8.0,  6.1,  9.7,  10.0, 8.0],  'Ik\'Thorne', '#BFBFFF'],
		6: [[8.1,  4.7,  8.8,  4.3,  8.1],  'Salvene',    '#00AA00'],
		7: [[10.0, 5.7,  8.7,  9.1,  10.0], 'Thevian',    '#800000'],
		8: [[7.2, 6.3,   7.9,  6.2,  7.2],  'WQ Human',   '#804040'],
		9: [[9.5, 4.9,   8.0,  5.1,  9.5],  'Nijarin',    '#FF8080']
	};
	
	var data = [
		{
			type: 'scatterpolar',
			r: [1.0, 1.0, 1.0, 1.0, 1.0],
			theta: ['Hunting', 'Trading', 'Combat', 'Utility', 'Hunting'],
			fill: 'toself',
			name: 'Neutral',
			line: {color: '#FFD800'},
			title: {
				text: 'Neutral'
			}
		}
	];

	var layout = {
		showlegend: false,
		polar: {
			radialaxis: {
				visible: true,
				showgrid: true,
				range: [0, 11],
				color: '#fff',
			},
			bgcolor: '#111'
		},
		paper_bgcolor: '#06240E',
		plot_bgcolor: '#000',
		font: {
			color: '#fff'
		},
		coloraxis : '#000'
	};
	var check = document.getElementsByClassName('plotly');
	if (check.length == 0) {

		Plotly.newPlot('graphframe', data, layout, {staticPlot: true});

	} 
	Plotly.animate('graphframe', {
		data: [{
			r: races[race_id][0],
			name: races[race_id][1],
			line: {color: races[race_id][2]},
		}],
		traces: [0],
		layout: {}
	}, {
		tansition: {
			duration: 500,
			easing: 'linear'
		},
		frame: {
			duration: 500
		}
	})
}
// Used by alliance_create.php and alliance_stat.php
function togglePassword(select) {
	var showPassword = $(select).val() === "password";
	// We need to both toggle the element display (for the user) and toggle the
	// disabled property (for the form submission).
	if (showPassword) {
		$("#password-display").show();
	} else {
		$("#password-display").hide();
	}
	$("#password-input").prop("disabled", !showPassword);
}


1			(function() {
2			"use strict";
3
4			window.voteSite = function(snUrl) {
5			// Must not redirect the current page until after the external vote
6			// site URL has been opened in a new tab. Use setTimeout to do this.
7			setTimeout(function() {
8			window.location = snUrl;
9			}, 0);
10			};
11
12			function doCalc(type, number, totalDest) {
13			var i = 1, total = 0, df=document.FORM;
14			for(; i<=number; i++) {
15			total += df[type+i].value * 1;
16			}
17			df[totalDest].value = total;
18			};
19
20			// Recalculate total number of ports, summing over level
21			window.levelCalc = function(maxPortLevel) {
22			doCalc('port', maxPortLevel, 'total');
23			};
24
25			// Recalculate sum of port race percentages
26			window.raceCalc = function() {
27			doCalc('race', 9, 'racedist');
28			};
29
30			// Set the total number of ports to zero
31			window.setZero = function(maxPortLevel) {
32			var df = document.FORM;
33			for (var i=1; i<=maxPortLevel; i++) {
34			df['port'+i].value = 0;
35			}
36			df.total.value = 0;
37			};
38
39			// Set the port race distribution to be equal
40			window.setEven = function() {
41			var i = 2, df=document.FORM;
42			df.race1.value = 12;
43			for(; i<=9; i++) {
44			df['race'+i].value = 11;
45			}
46			df.racedist.value = 100;
47			};
48
49			var body, currentlyFlashing=false, flashColour, origColour, intervalFlash, timeoutStopFlash;
50
51			function stopFlash() {
52			clearInterval(intervalFlash);
53			body.style.backgroundColor = origColour;
			0 ignored issues – show Bug introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report The variable `body` seems to be never initialized. Loading history...
54			currentlyFlashing = false;
55			};
56
57			function bgFlash() {
58			var body = document.getElementsByTagName('body')[0];
59			if(body.style.backgroundColor === origColour) {
60			body.style.backgroundColor = flashColour;
61			}
62			else {
63			body.style.backgroundColor = origColour;
64			}
65			};
66
67			window.triggerAttackBlink = function(colour) {
68			if(origColour == null) {
			0 ignored issues – show Best Practice introduced 2019-03-02 00:35 UTC by Report Bug Copy Issue Report Comparing `origColour` to `null` using the `==` operator is not safe. Consider using `===` instead. Loading history...
69			origColour = document.getElementsByTagName('body')[0].style.backgroundColor;
70			}
71			flashColour = '#'+colour;
72			clearTimeout(timeoutStopFlash);
73			if (currentlyFlashing === false) {
74			currentlyFlashing = true;
75			//flash 3 times
76			bgFlash();
77			intervalFlash = setInterval(bgFlash,500);
78			}
79			timeoutStopFlash = setTimeout(stopFlash,3500);
80			};
81			})();
82
83			// Used by shop_hardware.php
84			function recalcOnKeyUp(transaction, hardwareTypeID, cost) {
85			var form = document.getElementById(transaction + hardwareTypeID);
86			form.total.value = form.amount.value * cost;
87			}
88
89			// Used by planet_defense.php
90			function showWeaponInfo(select) {
91			var target = $(select).data('target');
92			var show = $("option:selected", select).data('show');
93			$(target).children().addClass('hide');
94			$(show).removeClass('hide');
95			}
96
97			// Used by game_join.php
98			function showRaceInfo(select) {
99			var race_id = $("option:selected", select).val();
100			document.getElementById('race_image').src = "images/race/race" + race_id + ".jpg";
101			document.getElementById('graphframe').src = "images/race/graph/graph" + race_id + ".gif";
102			var desc = document.getElementById('race_descr');
103			$(desc).children().addClass('hide');
104			$(".race_descr" + race_id, desc).removeClass('hide');
105			createRaceRadarChart(race_id);
106			}
107
108			// Used by game_join.php
109			function createRaceRadarChart(race_id) {
110
111			var races = {
112			1: [[1.0, 1.0, 1.0, 1.0, 1.0], 'Neutral', '#FFD800'],
113			2: [[5.2, 10.0, 5.8, 8.1, 5.2], 'Alskant', '#FF00FF'],
114			3: [[8.3, 5.0, 10.0, 3.3, 8.3], 'Creonti', '#FF8000'],
115			4: [[9.5, 4.9, 9.5, 7.7, 9.5], 'Human', '#0000FF'],
116			5: [[8.0, 6.1, 9.7, 10.0, 8.0], 'Ik\'Thorne', '#BFBFFF'],
117			6: [[8.1, 4.7, 8.8, 4.3, 8.1], 'Salvene', '#00AA00'],
118			7: [[10.0, 5.7, 8.7, 9.1, 10.0], 'Thevian', '#800000'],
119			8: [[7.2, 6.3, 7.9, 6.2, 7.2], 'WQ Human', '#804040'],
120			9: [[9.5, 4.9, 8.0, 5.1, 9.5], 'Nijarin', '#FF8080']
121			};
122
123			var data = [
124			{
125			type: 'scatterpolar',
126			r: [1.0, 1.0, 1.0, 1.0, 1.0],
127			theta: ['Hunting', 'Trading', 'Combat', 'Utility', 'Hunting'],
128			fill: 'toself',
129			name: 'Neutral',
130			line: {color: '#FFD800'},
131			title: {
132			text: 'Neutral'
133			}
134			}
135			];
136
137			var layout = {
138			showlegend: false,
139			polar: {
140			radialaxis: {
141			visible: true,
142			showgrid: true,
143			range: [0, 11],
144			color: '#fff',
145			},
146			bgcolor: '#111'
147			},
148			paper_bgcolor: '#06240E',
149			plot_bgcolor: '#000',
150			font: {
151			color: '#fff'
152			},
153			coloraxis : '#000'
154			};
155			var check = document.getElementsByClassName('plotly');
156			if (check.length == 0) {
			0 ignored issues – show Best Practice introduced 2020-12-12 21:47 UTC by Report Bug Copy Issue Report Comparing `check.length` to `0` using the `==` operator is not safe. Consider using `===` instead. Loading history...
157			Plotly.newPlot('graphframe', data, layout, {staticPlot: true});
			0 ignored issues – show Bug introduced 2020-12-09 04:11 UTC by Report Bug Copy Issue Report The variable `Plotly` seems to be never declared. If this is a global, consider adding a `/** global: Plotly */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
158			}
159			Plotly.animate('graphframe', {
160			data: [{
161			r: races[race_id][0],
162			name: races[race_id][1],
163			line: {color: races[race_id][2]},
164			}],
165			traces: [0],
166			layout: {}
167			}, {
168			tansition: {
169			duration: 500,
170			easing: 'linear'
171			},
172			frame: {
173			duration: 500
174			}
175			})
176			}
177			// Used by alliance_create.php and alliance_stat.php
178			function togglePassword(select) {
179			var showPassword = $(select).val() === "password";
180			// We need to both toggle the element display (for the user) and toggle the
181			// disabled property (for the form submission).
182			if (showPassword) {
183			$("#password-display").show();
184			} else {
185			$("#password-display").hide();
186			}
187			$("#password-input").prop("disabled", !showPassword);
188			}
189

smrealms / smr

Scrutinizer GitHub App not installed

Pull Request — master (#947)

smr15.js ➔ createRaceRadarChart B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like